Merge lp:~achiang/telegram-app/libqtelegram-click-prep-1 into lp:~libqtelegram-team/telegram-app/qml-plugin

Proposed by Alex Chiang
Status: Merged
Approved by: Michał Karnicki
Approved revision: 182
Merged at revision: 180
Proposed branch: lp:~achiang/telegram-app/libqtelegram-click-prep-1
Merge into: lp:~libqtelegram-team/telegram-app/qml-plugin
Diff against target: 160 lines (+20/-10)
11 files modified
lib/CMakeLists.txt (+4/-0)
lib/core/CMakeLists.txt (+2/-0)
lib/logic/CMakeLists.txt (+2/-1)
lib/types/CMakeLists.txt (+2/-0)
qmlplugin/CMakeLists.txt (+2/-1)
qmlplugin/qmldir (+2/-2)
qmlplugin/telegramplugin.h (+1/-1)
uitest/ui/ContactsPage.qml (+1/-1)
uitest/ui/DialogPage.qml (+2/-2)
uitest/ui/DialogsPageDesign.qml (+1/-1)
uitest/uitest.qml (+1/-1)
To merge this branch: bzr merge lp:~achiang/telegram-app/libqtelegram-click-prep-1
Reviewer Review Type Date Requested Status
Michał Karnicki (community) Approve
Review via email: mp+228967@code.launchpad.net

Description of the change

Some small changes to help make it easier to click package the app.

To post a comment you must log in.
Revision history for this message
Michał Karnicki (karni) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/CMakeLists.txt'
2--- lib/CMakeLists.txt 2014-07-08 17:43:44 +0000
3+++ lib/CMakeLists.txt 2014-07-30 23:43:46 +0000
4@@ -37,8 +37,10 @@
5 set(HEADERS
6 telegram.h
7 libqtelegram_global.h)
8+if(NOT CLICK_MODE)
9 INSTALL(FILES ${HEADERS}
10 DESTINATION ${CMAKE_INSTALL_PREFIX}/include/libqtelegram)
11+endif(NOT CLICK_MODE)
12
13 set(PREFIX "${CMAKE_INSTALL_PREFIX}")
14 set(EXEC_PREFIX "${CMAKE_INSTALL_PREFIX}")
15@@ -48,8 +50,10 @@
16 ${CMAKE_CURRENT_SOURCE_DIR}/qtelegram.pc.in
17 ${CMAKE_CURRENT_BINARY_DIR}/qtelegram.pc
18 @ONLY)
19+if(NOT CLICK_MODE)
20 INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/qtelegram.pc
21 DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig)
22+endif(NOT CLICK_MODE)
23
24 add_subdirectory(types)
25 add_subdirectory(core)
26
27=== modified file 'lib/core/CMakeLists.txt'
28--- lib/core/CMakeLists.txt 2014-07-08 04:13:10 +0000
29+++ lib/core/CMakeLists.txt 2014-07-30 23:43:46 +0000
30@@ -19,6 +19,8 @@
31 endpoint.h
32 sessionmanager.h)
33
34+if(NOT CLICK_MODE)
35 INSTALL(FILES ${CORE_HEADERS}
36 DESTINATION ${CMAKE_INSTALL_PREFIX}/include/libqtelegram/core)
37+endif(NOT CLICK_MODE)
38
39
40=== modified file 'lib/logic/CMakeLists.txt'
41--- lib/logic/CMakeLists.txt 2014-07-08 04:13:10 +0000
42+++ lib/logic/CMakeLists.txt 2014-07-30 23:43:46 +0000
43@@ -4,6 +4,7 @@
44 uploadfile.h
45 file.h)
46
47+if(NOT CLICK_MODE)
48 INSTALL(FILES ${LOGIC_HEADERS}
49 DESTINATION ${CMAKE_INSTALL_PREFIX}/include/libqtelegram/logic)
50-
51+endif(NOT CLICK_MODE)
52
53=== modified file 'lib/types/CMakeLists.txt'
54--- lib/types/CMakeLists.txt 2014-07-08 17:43:44 +0000
55+++ lib/types/CMakeLists.txt 2014-07-30 23:43:46 +0000
56@@ -61,5 +61,7 @@
57 chatlocated.h
58 types.h)
59
60+if(NOT CLICK_MODE)
61 INSTALL(FILES ${TYPES_HEADERS}
62 DESTINATION ${CMAKE_INSTALL_PREFIX}/include/libqtelegram/types)
63+endif(NOT CLICK_MODE)
64
65=== modified file 'qmlplugin/CMakeLists.txt'
66--- qmlplugin/CMakeLists.txt 2014-07-30 16:09:13 +0000
67+++ qmlplugin/CMakeLists.txt 2014-07-30 23:43:46 +0000
68@@ -14,9 +14,10 @@
69 endif (NOT QT_IMPORTS_DIR)
70
71 include_directories(${CMAKE_CURRENT_SOURCE_DIR})
72+include_directories(${libqtelegram_SOURCE_DIR}/lib)
73
74 set(QMLPLUGIN_NAME Telegram)
75-set(MODULE_NAME "Ubuntu.Plugins.Telegram")
76+set(MODULE_NAME "Telegram")
77
78
79 set(QMLPLUGIN_SRCS
80
81=== modified file 'qmlplugin/qmldir'
82--- qmlplugin/qmldir 2014-07-15 17:31:52 +0000
83+++ qmlplugin/qmldir 2014-07-30 23:43:46 +0000
84@@ -1,2 +1,2 @@
85-module Ubuntu.Plugins.Telegram
86-plugin Telegram
87\ No newline at end of file
88+module Telegram
89+plugin Telegram
90
91=== modified file 'qmlplugin/telegramplugin.h'
92--- qmlplugin/telegramplugin.h 2014-06-20 09:52:32 +0000
93+++ qmlplugin/telegramplugin.h 2014-07-30 23:43:46 +0000
94@@ -7,7 +7,7 @@
95 /*
96 ----8<-----
97
98- import Ubuntu.Plugins.Telegram 0.1
99+ import Telegram 0.1
100
101 Rectangle {
102 width: 200
103
104=== modified file 'uitest/ui/ContactsPage.qml'
105--- uitest/ui/ContactsPage.qml 2014-07-25 09:40:58 +0000
106+++ uitest/ui/ContactsPage.qml 2014-07-30 23:43:46 +0000
107@@ -1,7 +1,7 @@
108 import QtQuick 2.0
109 import Ubuntu.Components 0.1
110 import Ubuntu.Components.ListItems 0.1
111-import Ubuntu.Plugins.Telegram 0.1
112+import Telegram 0.1
113
114 Page {
115
116
117=== modified file 'uitest/ui/DialogPage.qml'
118--- uitest/ui/DialogPage.qml 2014-07-07 13:44:35 +0000
119+++ uitest/ui/DialogPage.qml 2014-07-30 23:43:46 +0000
120@@ -1,5 +1,5 @@
121 import QtQuick 2.0
122-import Ubuntu.Plugins.Telegram 0.1
123+import Telegram 0.1
124
125 DialogDesignPage {
126
127@@ -7,7 +7,7 @@
128 var message = sendMsgTextField.text;
129 if (message.length > 0) {
130 //Another option is creating the input object by using:
131- //var inputPeer = Qt.createQmlObject('import Ubuntu.Plugins.Telegram 0.1; TLInputPeer{}', dialogPage, null);
132+ //var inputPeer = Qt.createQmlObject('import Telegram 0.1; TLInputPeer{}', dialogPage, null);
133
134 if (peerIsChat) {
135 inputPeer.classType = TLInputPeer.TypeInputPeerChat;
136
137=== modified file 'uitest/ui/DialogsPageDesign.qml'
138--- uitest/ui/DialogsPageDesign.qml 2014-07-21 17:12:18 +0000
139+++ uitest/ui/DialogsPageDesign.qml 2014-07-30 23:43:46 +0000
140@@ -2,7 +2,7 @@
141 import Ubuntu.Components 0.1
142 import Ubuntu.Components.ListItems 0.1
143 import "../components/listitems"
144-import Ubuntu.Plugins.Telegram 0.1
145+import Telegram 0.1
146
147 Page {
148
149
150=== modified file 'uitest/uitest.qml'
151--- uitest/uitest.qml 2014-07-24 08:45:05 +0000
152+++ uitest/uitest.qml 2014-07-30 23:43:46 +0000
153@@ -1,6 +1,6 @@
154 import QtQuick 2.0
155 import Ubuntu.Components 0.1
156-import Ubuntu.Plugins.Telegram 0.1
157+import Telegram 0.1
158 import "ui"
159
160 /*!

Subscribers

People subscribed via source and target branches

to all changes: