Code review comment for lp:~achiang/hydrazine/batch-operations

Revision history for this message
Martin Pool (mbp) wrote :

thanks for the doc updates.

72 +Caution, without the 'filter' command, you will operate on ALL
73 +active bugs in your pillar, including bugs already Fix Committed.

[fix] That sounds kind of risky. Would it be at all practical to have it just fail if there is no filter? I think it would, just by after the 'for f' block

   else:
        print 'No filter set?'
        return

aside from that it looks good - thanks!

If you just fix that thing, please go ahead and land it.

review: Needs Fixing

« Back to merge proposal