Code review comment for lp:~acerisara/autopilot/move-to-object

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Just leaving this here as commentary on the change.

<thomi> balloons: veebers: I'm disturbed by the deletion of the docstring in that MP
<balloons> is there a more elegant way to do it, while still avoiding double documentation?
<thomi> are the two methods identical?
<balloons> mm.. I suppose it should actually have a docstring.. a unique one
<balloons> meh
<thomi> yeah
<thomi> and make that function public, and give it a docstring too
<balloons> I was thinking it was a duplication, but it's not purely one
<thomi> that way the docstring can say "moves the cursor to the center point of the object. See `autopilot.input.get_center_point` for details on how the center point is calculated'

« Back to merge proposal