Merge lp:~account-report-core-editor/account-financial-report/fix-opening-period-search into lp:~account-report-core-editor/account-financial-report/7.0
Proposed by
Niels Huylebroeck
Status: | Work in progress |
---|---|
Proposed branch: | lp:~account-report-core-editor/account-financial-report/fix-opening-period-search |
Merge into: | lp:~account-report-core-editor/account-financial-report/7.0 |
Diff against target: |
31 lines (+6/-15) 1 file modified
account_financial_report_webkit/report/common_partner_reports.py (+6/-15) |
To merge this branch: | bzr merge lp:~account-report-core-editor/account-financial-report/fix-opening-period-search |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pedro Manuel Baeza | Needs Resubmitting | ||
Maxime Chambreuil (http://www.savoirfairelinux.com) | Approve | ||
Frederic Clementi - Camptocamp | Disapprove | ||
Review via email: mp+162772@code.launchpad.net |
Description of the change
A fix for finding the first opening period.
We had a customer who had a backdated entry which confused the code, these adjustments should avoid such issues.
To post a comment you must log in.
Unmerged revisions
- 29. By Niels Huylebroeck
-
[FIX] account_
financial_ report_ webkit: fix issue where the search for the first opening period was confused if you had some account entry which was backdated
It now searches through the periods themselves while sorting on date_start ascending instead of looking at the "oldest" account entry.
hi,
I'm on my phone, in the train, so it's a bit difficult to be exhaustive. I
remember of a change in this method to fix a bug when a fiscal year had no
move lines at all. The goal was to exclude them.
I'll try to find the reason shortly.