Code review comment for lp:~abychko/percona-server/bug1099809

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Alexey,

The patch looks good except two minor things:

- I suggest "Build with Percona PAM plugin" instead of "Compiling
  Percona PAM AUTH libraries" as the option description.

- please revert all unrelated changes to the .spec file. Some of them
  are not safe, and other ones should be reported and fixed separately.

review: Needs Fixing

« Back to merge proposal