Code review comment for lp:~abychko/percona-server/bug1050654

Revision history for this message
Ignacio Nin (ignacio-nin) wrote :

> This looks good to me, but please get Ignacio's opinion.

Hello,

The patch looks good, however the description for lp:1050654 doesn't seem to describe correctly the bug/feature anymore, since the error reported doesn't apply anymore (also notice similarites to bug lp:1031427).

At the time, what does exactly the bug fix -- does it give compatibility with remi's repos? Also, should this be tested on Fedora?

Thanks!

review: Needs Information

« Back to merge proposal