Code review comment for lp:~abudden/qbzr/tab-width-on-view-menu

Revision history for this message
Alexander Belchenko (bialix) wrote :

Your both util functions are extended to get aditional parameter tab_width, but their signatures different:

def get_set_tab_width_chars(tab_width=None, branch=None):
vs
def get_tab_width_pixels(branch=None, tab_width_chars=None):

As I undersstand in both cases you might pass optional tab_width in chars. I think we should use the same order of arguments in both functions to reduce the possible mistakes in usage of that API. I'm asking you for consistency between those 2 functions. Can you fix this please?

« Back to merge proposal