Merge lp:~abrody/launchpad/https-mirror-dbchange into lp:launchpad/db-devel

[Andy Brody]

Add column DistributionMirror.https_base_url, which is needed to add support for listing HTTPS archive and release mirrors.

[Colin Watson (cjwatson)]

This needs to be re-prepared as a branch from lp:launchpad/db-devel, and proposed as a merge into lp:launchpad/db-devel. We can't land database patches against devel directly, except in a few specialised circumstances. Furthermore, the code branch (lp:~abrody/launchpad/https-mirror) may not declare the DB branch as a prerequisite; it must instead be a separate branch that doesn't itself contain the DB changes. This is all because database and code updates are deployed from separate branches; see https://dev.launchpad.net/PolicyAndProcess/DatabaseSchemaChangesProcess.

review: Needs Resubmitting

[Andy Brody (abrody)]

Thanks for the explanation, resubmitted.

[Colin Watson (cjwatson)]

This looks OK. I've allocated patch number 2210-03-0 for you, so please renumber this to use that.

review: Approve

[Colin Watson (cjwatson)]

Thiago picked this up in https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/379504, which is now on production.

Unmerged revisions

14020. By Andy Brody on 2019-02-08

Add DistributionMirror.https_base_url column.

=== added file 'database/schema/patch-2209-99-0.sql'
--- database/schema/patch-2209-99-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-99-0.sql	2019-02-08 06:52:29 +0000
@@ -0,0 +1,15 @@
+-- Copyright 2019 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE DistributionMirror
+    ADD COLUMN https_base_url text,
+    ADD CONSTRAINT distributionmirror_https_base_url_key UNIQUE (https_base_url),
+    ADD CONSTRAINT valid_https_base_url CHECK (valid_absolute_url(https_base_url)),
+    DROP CONSTRAINT one_or_more_urls,
+    ADD CONSTRAINT one_or_more_urls CHECK (http_base_url IS NOT NULL OR https_base_url IS NOT NULL OR ftp_base_url IS NOT NULL OR rsync_base_url IS NOT NULL);
+
+COMMENT ON COLUMN DistributionMirror.https_base_url IS 'The HTTPS URL used to access the mirror.';
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 99, 0);