Code review comment for lp:~abreu-alexandre/webbrowser-app/window-open-overlay

Revision history for this message
Olivier Tilloy (osomon) wrote :

Not sure exactly what the intended UX behaviour is (the spec is a bit summary), this is what I’m seeing when testing on the desktop:

 - The animation to open an overlay is quite fast, almost imperceptible (could we maybe make it a tad slower?)

 - When dismissing an overlay (by dragging it downwards or clicking on the chevron), it’s destroyed, right? I’m thinking that in that case maybe a cross icon would be more appropriate than a chevron, but of course that’s for a visual designer to decide.

 - When opening an overlay, the current webview seems to be hidden instantaneously, it should be hidden only once the animation has completed.

 - Similarly, when dragging an overlay downwards, nothing is visible behind, I think the main webview (or the previous overlay if any) should be visible.

 - After opening 3 overlays, the fourth external link gets open in my desktop browser (chromium) as expected, but then after closing one overlay and starting to re-open more external links, I got in a situation where blank chromium windows would open instead of a new tab in the current instance, this is weird (tested with initially opening the container on http://plus.google.com). When that happens, I’m seeing the following message on the console:

    qml: Maximum number of popup overlay opened, opening: about:blank in the browser

« Back to merge proposal