webbrowser-app

Code review comment for lp:~abreu-alexandre/webbrowser-app/webapp-navigation-handling

  1. webapp-navigation-handling
  2. Merge into trunk
Revision history for this message
Olivier Tilloy (osomon) wrote :

> > 226 + property alias includes: browser.urlIncludesPatterns
> >
> > Can this property be renamed to something more explicit? I’d like to see
> > 'webapps' in the name, to make it crystal clear that this property affects
> > only webapps.
>
> done.

Thanks. Could you also rename the command-line argument and the property of the CommandLineParser class, for consistency?

« Back to merge proposal