Code review comment for lp:~abreu-alexandre/webbrowser-app/webapp-navigation-handling

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> 82 + var matched = false;
>
> Instead of using an intermediate boolean var, how about initially setting
> action to WebView.IgnoreRequest just before the for loop, and if a given
> include pattern matches, set it to WebView.AcceptRequest ?

good idea, done

« Back to merge proposal