Code review comment for lp:~abreu-alexandre/webbrowser-app/support-oxide-and-qtwebkit

Olivier Tilloy (osomon) wrote :

This doesn’t work here on my device: I’ve installed packages built from this branch (which pulled in oxide), and running a webapp that has version 1.0 of the policy fails, I’m seeing this in the log:

    Using Oxide as the web engine backend

and then:

    LaunchProcess: failed to execvp:

QFile::exists() is probably not good enough to check access rights.
I have tried the following:

    return QFile(oxideHintLocation).open(QIODevice::ReadOnly);

which is closer to your original solution, but I’m still getting the same issue. Could it be that version 1.0 of the policy doesn’t prevent from reading this file? Can you check with Jamie?

review: Needs Fixing

« Back to merge proposal