Code review comment for lp:~abreu-alexandre/webbrowser-app/intent

Revision history for this message
Olivier Tilloy (osomon) wrote :

I’m not seeing the handleIntentUri() function being called anywhere.

And to be honest I’m not sure I understand the whole logic of this change.

Here is my understanding of how it should work: when an intent:// URL is clicked either in the browser or in a webapp, its handling will be delegated to the URL dispatcher, which will special case it to determine which app to target with it. The app will be invoked with the intent:// URL unchanged, so in the case of a webapp that registered for it, it needs to transform this URL to a valid http:// one.

So there are two places in the webapp-container’s code that need to handle such a transformation:
 - if the app was not previously running, it will be invoked with the intent:// URL as a parameter, the transformation needs to happen before setting the URL on the webview
 - if the app was already running, the UriHandler.onOpened handler needs to do the transformation

From a quick glance at the code, I don’t see this happening. Can you shed a light on this please?

« Back to merge proposal