Code review comment for lp:~abreu-alexandre/webbrowser-app/handle-webapp-renderer-crash

Revision history for this message
Olivier Tilloy (osomon) wrote :

Has this been signed off by the design team? I mentioned to them last week that you were going to implement something similar to what exists in the browser for the webapp container, and they agreed that the wording might require some tweaking. The mention of "tabs" in the default sad tab message that is used for the browser might be misleading in the context of the webapp container, especially if no overlay is currently being displayed.

One tiny remark: the SadTab autopilot proxy object should be defined in test_sad_tab.py, since it’s not used anywhere else.

Other than that, this looks good to me and seems to work well.

« Back to merge proposal