Merge lp:~abreu-alexandre/webbrowser-app/fix-uri-handler into lp:webbrowser-app

Proposed by Alexandre Abreu
Status: Merged
Approved by: Olivier Tilloy
Approved revision: no longer in the source branch.
Merged at revision: 661
Proposed branch: lp:~abreu-alexandre/webbrowser-app/fix-uri-handler
Merge into: lp:webbrowser-app
Diff against target: 16 lines (+4/-2)
1 file modified
src/app/webcontainer/webapp-container.qml (+4/-2)
To merge this branch: bzr merge lp:~abreu-alexandre/webbrowser-app/fix-uri-handler
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+229993@code.launchpad.net

Commit message

Fix URI handling by the webapp container.

Description of the change

Fix Uri Handling

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
658. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM.

review: Approve
659. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

660. By Alexandre Abreu

Add devtools support & ubuntu webview remote debugging
Approved by: PS Jenkins bot, Olivier Tilloy

661. By Alexandre Abreu

Fix URI handling by the webapp container. Fixes: 1342129
Approved by: PS Jenkins bot, Olivier Tilloy

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/webcontainer/webapp-container.qml'
--- src/app/webcontainer/webapp-container.qml 2014-08-05 10:53:57 +0000
+++ src/app/webcontainer/webapp-container.qml 2014-08-07 19:17:30 +0000
@@ -179,8 +179,10 @@
179 target: UriHandler179 target: UriHandler
180 onOpened: {180 onOpened: {
181 // only consider the first one (if multiple)181 // only consider the first one (if multiple)
182 if (uris.length !== 0) {182 if (uris.length !== 0
183 url = uris[0];183 && webappPageComponentLoader.item
184 && webappPageComponentLoader.item.currentWebview) {
185 webappPageComponentLoader.item.currentWebview.url = uris[0];
184 }186 }
185 }187 }
186 }188 }

Subscribers

People subscribed via source and target branches

to status/vote changes: