Merge lp:~abreu-alexandre/webapps-demo/update-to-webapp-container into lp:webapps-demo

Proposed by Alexandre Abreu
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 34
Merged at revision: 34
Proposed branch: lp:~abreu-alexandre/webapps-demo/update-to-webapp-container
Merge into: lp:webapps-demo
Diff against target: 103 lines (+8/-8)
8 files modified
debian/control (+1/-1)
tests/autopilot/webapps_click_packages_autopilot/tests/__init__.py (+1/-1)
webapp-amazon/webapp-amazon.desktop (+1/-1)
webapp-ebay/webapp-ebay.desktop (+1/-1)
webapp-facebook/webapp-facebook.desktop (+1/-1)
webapp-gmail/webapp-gmail.desktop (+1/-1)
webapp-twitter/webapp-twitter.desktop (+1/-1)
webapp-ubuntuone/webapp-ubuntuone.desktop (+1/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/webapps-demo/update-to-webapp-container
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+200858@code.launchpad.net

Commit message

Update the webapp launcher to the new webapp container (merged "upstream" & to be released)

Description of the change

Update the webapp launcher to the new webapp container (merged "upstream" & to be released)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2013-10-17 14:12:55 +0000
+++ debian/control 2014-01-08 15:45:26 +0000
@@ -13,7 +13,7 @@
13Depends: ${shlibs:Depends},13Depends: ${shlibs:Depends},
14 ${misc:Depends},14 ${misc:Depends},
15 webapps-demo,15 webapps-demo,
16 webbrowser-app,16 webapp-container,
17 qtdeclarative5-hud1.0,17 qtdeclarative5-hud1.0,
18 click,18 click,
19Description: Default web applications set (as click packages)19Description: Default web applications set (as click packages)
2020
=== modified file 'tests/autopilot/webapps_click_packages_autopilot/tests/__init__.py'
--- tests/autopilot/webapps_click_packages_autopilot/tests/__init__.py 2013-10-11 18:38:34 +0000
+++ tests/autopilot/webapps_click_packages_autopilot/tests/__init__.py 2014-01-08 15:45:26 +0000
@@ -33,7 +33,7 @@
33 output, errors = subprocess.Popen(["-c", command], stderr=subprocess.STDOUT, stdout=subprocess.PIPE, shell=True).communicate()33 output, errors = subprocess.Popen(["-c", command], stderr=subprocess.STDOUT, stdout=subprocess.PIPE, shell=True).communicate()
34 pid = ""34 pid = ""
35 if output and len(output) != 0:35 if output and len(output) != 0:
36 click_webapp_re = re.compile('.*webbrowser-app.*--webapp\s+.*{0}.*'.format(app_id))36 click_webapp_re = re.compile('.*webapp-container.*--webapp\s+.*{0}.*'.format(app_id))
37 pids = [process for process in output.split('\n') if click_webapp_re.match(process)]37 pids = [process for process in output.split('\n') if click_webapp_re.match(process)]
38 if len(pids) != 0:38 if len(pids) != 0:
39 pid = pids[0].split()[1]39 pid = pids[0].split()[1]
4040
=== modified file 'webapp-amazon/webapp-amazon.desktop'
--- webapp-amazon/webapp-amazon.desktop 2013-09-26 14:15:07 +0000
+++ webapp-amazon/webapp-amazon.desktop 2014-01-08 15:45:26 +0000
@@ -1,7 +1,7 @@
1[Desktop Entry]1[Desktop Entry]
2Type=Application2Type=Application
3Terminal=false3Terminal=false
4Exec=webbrowser-app --enable-back-forward --webapp --webappUrlPatterns=https?://www.amazon.com/*,https?://s.amazon-adsystem.com/* http://www.amazon.com/gp/aw4Exec=webapp-container --enable-back-forward --webapp --webappUrlPatterns=https?://www.amazon.com/*,https?://s.amazon-adsystem.com/* http://www.amazon.com/gp/aw
5Name=Amazon5Name=Amazon
6Icon=./amazon.png6Icon=./amazon.png
7X-Ubuntu-Touch=true7X-Ubuntu-Touch=true
88
=== modified file 'webapp-ebay/webapp-ebay.desktop'
--- webapp-ebay/webapp-ebay.desktop 2013-10-16 16:36:55 +0000
+++ webapp-ebay/webapp-ebay.desktop 2014-01-08 15:45:26 +0000
@@ -1,7 +1,7 @@
1[Desktop Entry]1[Desktop Entry]
2Type=Application2Type=Application
3Terminal=false3Terminal=false
4Exec=webbrowser-app --enable-back-forward --webappUrlPatterns=https?://*.ebay.com/* --webapp http://m.ebay.com/4Exec=webapp-container --enable-back-forward --webappUrlPatterns=https?://*.ebay.com/* --webapp http://m.ebay.com/
5Name=eBay5Name=eBay
6Icon=./ebay.png6Icon=./ebay.png
7X-Ubuntu-Touch=true7X-Ubuntu-Touch=true
88
=== modified file 'webapp-facebook/webapp-facebook.desktop'
--- webapp-facebook/webapp-facebook.desktop 2013-09-26 16:17:53 +0000
+++ webapp-facebook/webapp-facebook.desktop 2014-01-08 15:45:26 +0000
@@ -1,7 +1,7 @@
1[Desktop Entry]1[Desktop Entry]
2Type=Application2Type=Application
3Terminal=false3Terminal=false
4Exec=webbrowser-app --enable-back-forward --webapp --webappUrlPatterns=https?://m.facebook.com/* https://m.facebook.com/4Exec=webapp-container --enable-back-forward --webapp --webappUrlPatterns=https?://m.facebook.com/* https://m.facebook.com/
5Name=Facebook5Name=Facebook
6Icon=./facebook.png6Icon=./facebook.png
7X-Ubuntu-Touch=true7X-Ubuntu-Touch=true
88
=== modified file 'webapp-gmail/webapp-gmail.desktop'
--- webapp-gmail/webapp-gmail.desktop 2013-10-11 16:04:22 +0000
+++ webapp-gmail/webapp-gmail.desktop 2014-01-08 15:45:26 +0000
@@ -1,7 +1,7 @@
1[Desktop Entry]1[Desktop Entry]
2Type=Application2Type=Application
3Terminal=false3Terminal=false
4Exec=webbrowser-app --enable-back-forward --webappModelSearchPath=. --webapp='R01haWwNCg==' https://mail.google.com/4Exec=webapp-container --enable-back-forward --webappModelSearchPath=. --webapp='R01haWwNCg==' https://mail.google.com/
5Name=Gmail5Name=Gmail
6Icon=./gmail.png6Icon=./gmail.png
7X-Ubuntu-Touch=true7X-Ubuntu-Touch=true
88
=== modified file 'webapp-twitter/webapp-twitter.desktop'
--- webapp-twitter/webapp-twitter.desktop 2013-10-10 19:46:34 +0000
+++ webapp-twitter/webapp-twitter.desktop 2014-01-08 15:45:26 +0000
@@ -1,7 +1,7 @@
1[Desktop Entry]1[Desktop Entry]
2Type=Application2Type=Application
3Terminal=false3Terminal=false
4Exec=webbrowser-app --enable-back-forward --webapp --webappUrlPatterns=https?://mobile.twitter.com/* https://mobile.twitter.com/session/new?bypass_interstitial=true4Exec=webapp-container --enable-back-forward --webapp --webappUrlPatterns=https?://mobile.twitter.com/* https://mobile.twitter.com/session/new?bypass_interstitial=true
5Name=Twitter5Name=Twitter
6Icon=./twitter.png6Icon=./twitter.png
7X-Ubuntu-Touch=true7X-Ubuntu-Touch=true
88
=== modified file 'webapp-ubuntuone/webapp-ubuntuone.desktop'
--- webapp-ubuntuone/webapp-ubuntuone.desktop 2013-09-26 16:17:53 +0000
+++ webapp-ubuntuone/webapp-ubuntuone.desktop 2014-01-08 15:45:26 +0000
@@ -1,7 +1,7 @@
1[Desktop Entry]1[Desktop Entry]
2Type=Application2Type=Application
3Terminal=false3Terminal=false
4Exec=webbrowser-app --enable-back-forward --webappUrlPatterns=https?://one.ubuntu.com/*,https?://login.ubuntu.com/* --webapp https://one.ubuntu.com/4Exec=webapp-container --enable-back-forward --webappUrlPatterns=https?://one.ubuntu.com/*,https?://login.ubuntu.com/* --webapp https://one.ubuntu.com/
5Name=Ubuntu One5Name=Ubuntu One
6Icon=./ubuntuone.png6Icon=./ubuntuone.png
7X-Ubuntu-Touch=true7X-Ubuntu-Touch=true

Subscribers

People subscribed via source and target branches