Merge lp:~abreu-alexandre/webapps-demo/update-to-webapp-container into lp:webapps-demo

Proposed by Alexandre Abreu
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 34
Merged at revision: 34
Proposed branch: lp:~abreu-alexandre/webapps-demo/update-to-webapp-container
Merge into: lp:webapps-demo
Diff against target: 103 lines (+8/-8)
8 files modified
debian/control (+1/-1)
tests/autopilot/webapps_click_packages_autopilot/tests/__init__.py (+1/-1)
webapp-amazon/webapp-amazon.desktop (+1/-1)
webapp-ebay/webapp-ebay.desktop (+1/-1)
webapp-facebook/webapp-facebook.desktop (+1/-1)
webapp-gmail/webapp-gmail.desktop (+1/-1)
webapp-twitter/webapp-twitter.desktop (+1/-1)
webapp-ubuntuone/webapp-ubuntuone.desktop (+1/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/webapps-demo/update-to-webapp-container
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+200858@code.launchpad.net

Commit message

Update the webapp launcher to the new webapp container (merged "upstream" & to be released)

Description of the change

Update the webapp launcher to the new webapp container (merged "upstream" & to be released)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-10-17 14:12:55 +0000
3+++ debian/control 2014-01-08 15:45:26 +0000
4@@ -13,7 +13,7 @@
5 Depends: ${shlibs:Depends},
6 ${misc:Depends},
7 webapps-demo,
8- webbrowser-app,
9+ webapp-container,
10 qtdeclarative5-hud1.0,
11 click,
12 Description: Default web applications set (as click packages)
13
14=== modified file 'tests/autopilot/webapps_click_packages_autopilot/tests/__init__.py'
15--- tests/autopilot/webapps_click_packages_autopilot/tests/__init__.py 2013-10-11 18:38:34 +0000
16+++ tests/autopilot/webapps_click_packages_autopilot/tests/__init__.py 2014-01-08 15:45:26 +0000
17@@ -33,7 +33,7 @@
18 output, errors = subprocess.Popen(["-c", command], stderr=subprocess.STDOUT, stdout=subprocess.PIPE, shell=True).communicate()
19 pid = ""
20 if output and len(output) != 0:
21- click_webapp_re = re.compile('.*webbrowser-app.*--webapp\s+.*{0}.*'.format(app_id))
22+ click_webapp_re = re.compile('.*webapp-container.*--webapp\s+.*{0}.*'.format(app_id))
23 pids = [process for process in output.split('\n') if click_webapp_re.match(process)]
24 if len(pids) != 0:
25 pid = pids[0].split()[1]
26
27=== modified file 'webapp-amazon/webapp-amazon.desktop'
28--- webapp-amazon/webapp-amazon.desktop 2013-09-26 14:15:07 +0000
29+++ webapp-amazon/webapp-amazon.desktop 2014-01-08 15:45:26 +0000
30@@ -1,7 +1,7 @@
31 [Desktop Entry]
32 Type=Application
33 Terminal=false
34-Exec=webbrowser-app --enable-back-forward --webapp --webappUrlPatterns=https?://www.amazon.com/*,https?://s.amazon-adsystem.com/* http://www.amazon.com/gp/aw
35+Exec=webapp-container --enable-back-forward --webapp --webappUrlPatterns=https?://www.amazon.com/*,https?://s.amazon-adsystem.com/* http://www.amazon.com/gp/aw
36 Name=Amazon
37 Icon=./amazon.png
38 X-Ubuntu-Touch=true
39
40=== modified file 'webapp-ebay/webapp-ebay.desktop'
41--- webapp-ebay/webapp-ebay.desktop 2013-10-16 16:36:55 +0000
42+++ webapp-ebay/webapp-ebay.desktop 2014-01-08 15:45:26 +0000
43@@ -1,7 +1,7 @@
44 [Desktop Entry]
45 Type=Application
46 Terminal=false
47-Exec=webbrowser-app --enable-back-forward --webappUrlPatterns=https?://*.ebay.com/* --webapp http://m.ebay.com/
48+Exec=webapp-container --enable-back-forward --webappUrlPatterns=https?://*.ebay.com/* --webapp http://m.ebay.com/
49 Name=eBay
50 Icon=./ebay.png
51 X-Ubuntu-Touch=true
52
53=== modified file 'webapp-facebook/webapp-facebook.desktop'
54--- webapp-facebook/webapp-facebook.desktop 2013-09-26 16:17:53 +0000
55+++ webapp-facebook/webapp-facebook.desktop 2014-01-08 15:45:26 +0000
56@@ -1,7 +1,7 @@
57 [Desktop Entry]
58 Type=Application
59 Terminal=false
60-Exec=webbrowser-app --enable-back-forward --webapp --webappUrlPatterns=https?://m.facebook.com/* https://m.facebook.com/
61+Exec=webapp-container --enable-back-forward --webapp --webappUrlPatterns=https?://m.facebook.com/* https://m.facebook.com/
62 Name=Facebook
63 Icon=./facebook.png
64 X-Ubuntu-Touch=true
65
66=== modified file 'webapp-gmail/webapp-gmail.desktop'
67--- webapp-gmail/webapp-gmail.desktop 2013-10-11 16:04:22 +0000
68+++ webapp-gmail/webapp-gmail.desktop 2014-01-08 15:45:26 +0000
69@@ -1,7 +1,7 @@
70 [Desktop Entry]
71 Type=Application
72 Terminal=false
73-Exec=webbrowser-app --enable-back-forward --webappModelSearchPath=. --webapp='R01haWwNCg==' https://mail.google.com/
74+Exec=webapp-container --enable-back-forward --webappModelSearchPath=. --webapp='R01haWwNCg==' https://mail.google.com/
75 Name=Gmail
76 Icon=./gmail.png
77 X-Ubuntu-Touch=true
78
79=== modified file 'webapp-twitter/webapp-twitter.desktop'
80--- webapp-twitter/webapp-twitter.desktop 2013-10-10 19:46:34 +0000
81+++ webapp-twitter/webapp-twitter.desktop 2014-01-08 15:45:26 +0000
82@@ -1,7 +1,7 @@
83 [Desktop Entry]
84 Type=Application
85 Terminal=false
86-Exec=webbrowser-app --enable-back-forward --webapp --webappUrlPatterns=https?://mobile.twitter.com/* https://mobile.twitter.com/session/new?bypass_interstitial=true
87+Exec=webapp-container --enable-back-forward --webapp --webappUrlPatterns=https?://mobile.twitter.com/* https://mobile.twitter.com/session/new?bypass_interstitial=true
88 Name=Twitter
89 Icon=./twitter.png
90 X-Ubuntu-Touch=true
91
92=== modified file 'webapp-ubuntuone/webapp-ubuntuone.desktop'
93--- webapp-ubuntuone/webapp-ubuntuone.desktop 2013-09-26 16:17:53 +0000
94+++ webapp-ubuntuone/webapp-ubuntuone.desktop 2014-01-08 15:45:26 +0000
95@@ -1,7 +1,7 @@
96 [Desktop Entry]
97 Type=Application
98 Terminal=false
99-Exec=webbrowser-app --enable-back-forward --webappUrlPatterns=https?://one.ubuntu.com/*,https?://login.ubuntu.com/* --webapp https://one.ubuntu.com/
100+Exec=webapp-container --enable-back-forward --webappUrlPatterns=https?://one.ubuntu.com/*,https?://login.ubuntu.com/* --webapp https://one.ubuntu.com/
101 Name=Ubuntu One
102 Icon=./ubuntuone.png
103 X-Ubuntu-Touch=true

Subscribers

People subscribed via source and target branches