Code review comment for lp:~abreu-alexandre/v8-cpp/fix-constructor-var-args

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

These changes have broken 2 other tests:

marcustomlinson@ubuntu:~/Projects/work/v8-cpp/trunk-build$ make test
Running tests...
Test project /home/marcustomlinson/Projects/work/v8-cpp/trunk-build
    Start 1: test-errors
1/6 Test #1: test-errors ...................... Passed 0.23 sec
    Start 2: test-functions
2/6 Test #2: test-functions ................... Passed 0.07 sec
    Start 3: test-members
3/6 Test #3: test-members ..................... Passed 0.02 sec
    Start 4: test-methods
4/6 Test #4: test-methods .....................***Failed 0.07 sec
    Start 5: test-objects
5/6 Test #5: test-objects ..................... Passed 0.10 sec
    Start 6: test-run
6/6 Test #6: test-run .........................***Failed 0.03 sec

67% tests passed, 2 tests failed out of 6

Total Test time (real) = 0.52 sec

The following tests FAILED:
   4 - test-methods (Failed)
   6 - test-run (Failed)
Errors while running CTest
Makefile:75: recipe for target 'test' failed
make: *** [test] Error 8

review: Needs Fixing

« Back to merge proposal