Merge lp:~abreu-alexandre/unity-webapps-qml/oxide-1.0 into lp:unity-webapps-qml

Proposed by Alexandre Abreu
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 107
Merged at revision: 109
Proposed branch: lp:~abreu-alexandre/unity-webapps-qml/oxide-1.0
Merge into: lp:unity-webapps-qml
Diff against target: 41 lines (+3/-3)
2 files modified
debian/control (+1/-1)
src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js (+2/-2)
To merge this branch: bzr merge lp:~abreu-alexandre/unity-webapps-qml/oxide-1.0
Reviewer Review Type Date Requested Status
Olivier Tilloy (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+213902@code.launchpad.net

Commit message

Update the oxide bits to account for oxide moving to 1.0

Description of the change

*** DO NOT TOP APPROVE UNTIL OXIDE 1.0 HAS BEEN RELEASED ***

Update the oxide bits to account for oxide moving to 1.0

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
107. By Alexandre Abreu

switch to oxide 1.0

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

+ liboxideqt-qmlplugin (>= 1.0),

I don’t think the version number is necessary here (nor meaningful, because the current release is 1.0.0~bzr452-0ubuntu1 for which imports version is 0.1).

Revision history for this message
Olivier Tilloy (osomon) wrote :

Approving anyway, as the version number requirement doesn’t hurt (it can be removed later).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2014-03-25 18:14:09 +0000
+++ debian/control 2014-04-03 14:17:34 +0000
@@ -27,6 +27,7 @@
27Package: unity-webapps-qml27Package: unity-webapps-qml
28Architecture: any28Architecture: any
29Depends: libqt5webkit5-qmlwebkitplugin,29Depends: libqt5webkit5-qmlwebkitplugin,
30 liboxideqt-qmlplugin (>= 1.0),
30 qtdeclarative5-qtquick2-plugin,31 qtdeclarative5-qtquick2-plugin,
31 qtdeclarative5-unity-action-plugin,32 qtdeclarative5-unity-action-plugin,
32 qtdeclarative5-ubuntu-ui-toolkit-plugin,33 qtdeclarative5-ubuntu-ui-toolkit-plugin,
@@ -34,7 +35,6 @@
34 ${misc:Depends},35 ${misc:Depends},
35 ${shlibs:Depends},36 ${shlibs:Depends},
36Suggests: qtdeclarative5-ubuntu-content0.1,37Suggests: qtdeclarative5-ubuntu-content0.1,
37 liboxideqt-qmlplugin,
38Description: Unity Webapps QML component38Description: Unity Webapps QML component
39 Unity Webapps QML is a QML component that binds to a QML WebView and allows39 Unity Webapps QML is a QML component that binds to a QML WebView and allows
40 running javascript code to access Ubuntu stack components.40 running javascript code to access Ubuntu stack components.
4141
=== modified file 'src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js'
--- src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js 2014-03-20 18:35:00 +0000
+++ src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js 2014-04-03 14:17:34 +0000
@@ -69,7 +69,7 @@
69 var context = this.webview.context;69 var context = this.webview.context;
7070
71 for (var i = 0; i < userScriptUrls.length; ++i) {71 for (var i = 0; i < userScriptUrls.length; ++i) {
72 var scriptStart = "import com.canonical.Oxide 0.1 as Oxide; Oxide.UserScript { context:";72 var scriptStart = "import com.canonical.Oxide 1.0 as Oxide; Oxide.UserScript { context:";
73 var scriptEnd = "}";73 var scriptEnd = "}";
74 var statement = scriptStart +74 var statement = scriptStart +
75 '"' + this._WEBAPPS_USER_SCRIPT_CONTEXT + '"' +75 '"' + this._WEBAPPS_USER_SCRIPT_CONTEXT + '"' +
@@ -96,7 +96,7 @@
96 onMessageReceived(msg.args);96 onMessageReceived(msg.args);
97 }97 }
9898
99 var script = 'import com.canonical.Oxide 0.1 as Oxide; ' +99 var script = 'import com.canonical.Oxide 1.0 as Oxide; ' +
100 ' Oxide.ScriptMessageHandler { msgId: "UnityWebappApi-Message"; contexts: ["' +100 ' Oxide.ScriptMessageHandler { msgId: "UnityWebappApi-Message"; contexts: ["' +
101 this._WEBAPPS_USER_SCRIPT_CONTEXT +101 this._WEBAPPS_USER_SCRIPT_CONTEXT +
102 '"]; ' +102 '"]; ' +

Subscribers

People subscribed via source and target branches

to all changes: