Merge lp:~abreu-alexandre/unity-webapps-qml/oxide-1.0 into lp:unity-webapps-qml

Proposed by Alexandre Abreu
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 107
Merged at revision: 109
Proposed branch: lp:~abreu-alexandre/unity-webapps-qml/oxide-1.0
Merge into: lp:unity-webapps-qml
Diff against target: 41 lines (+3/-3)
2 files modified
debian/control (+1/-1)
src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js (+2/-2)
To merge this branch: bzr merge lp:~abreu-alexandre/unity-webapps-qml/oxide-1.0
Reviewer Review Type Date Requested Status
Olivier Tilloy (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+213902@code.launchpad.net

Commit message

Update the oxide bits to account for oxide moving to 1.0

Description of the change

*** DO NOT TOP APPROVE UNTIL OXIDE 1.0 HAS BEEN RELEASED ***

Update the oxide bits to account for oxide moving to 1.0

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
107. By Alexandre Abreu

switch to oxide 1.0

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

+ liboxideqt-qmlplugin (>= 1.0),

I don’t think the version number is necessary here (nor meaningful, because the current release is 1.0.0~bzr452-0ubuntu1 for which imports version is 0.1).

Revision history for this message
Olivier Tilloy (osomon) wrote :

Approving anyway, as the version number requirement doesn’t hurt (it can be removed later).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-03-25 18:14:09 +0000
3+++ debian/control 2014-04-03 14:17:34 +0000
4@@ -27,6 +27,7 @@
5 Package: unity-webapps-qml
6 Architecture: any
7 Depends: libqt5webkit5-qmlwebkitplugin,
8+ liboxideqt-qmlplugin (>= 1.0),
9 qtdeclarative5-qtquick2-plugin,
10 qtdeclarative5-unity-action-plugin,
11 qtdeclarative5-ubuntu-ui-toolkit-plugin,
12@@ -34,7 +35,6 @@
13 ${misc:Depends},
14 ${shlibs:Depends},
15 Suggests: qtdeclarative5-ubuntu-content0.1,
16- liboxideqt-qmlplugin,
17 Description: Unity Webapps QML component
18 Unity Webapps QML is a QML component that binds to a QML WebView and allows
19 running javascript code to access Ubuntu stack components.
20
21=== modified file 'src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js'
22--- src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js 2014-03-20 18:35:00 +0000
23+++ src/Ubuntu/UnityWebApps/UnityWebAppsUtils.js 2014-04-03 14:17:34 +0000
24@@ -69,7 +69,7 @@
25 var context = this.webview.context;
26
27 for (var i = 0; i < userScriptUrls.length; ++i) {
28- var scriptStart = "import com.canonical.Oxide 0.1 as Oxide; Oxide.UserScript { context:";
29+ var scriptStart = "import com.canonical.Oxide 1.0 as Oxide; Oxide.UserScript { context:";
30 var scriptEnd = "}";
31 var statement = scriptStart +
32 '"' + this._WEBAPPS_USER_SCRIPT_CONTEXT + '"' +
33@@ -96,7 +96,7 @@
34 onMessageReceived(msg.args);
35 }
36
37- var script = 'import com.canonical.Oxide 0.1 as Oxide; ' +
38+ var script = 'import com.canonical.Oxide 1.0 as Oxide; ' +
39 ' Oxide.ScriptMessageHandler { msgId: "UnityWebappApi-Message"; contexts: ["' +
40 this._WEBAPPS_USER_SCRIPT_CONTEXT +
41 '"]; ' +

Subscribers

People subscribed via source and target branches

to all changes: