Code review comment for lp:~abreu-alexandre/unity-webapps-qml/fix-autopilot-tests-and-handle-local-apps

Revision history for this message
David Barth (dbarth) wrote :

Just reacting to the following part:

//FIXME: think of a better way to handle desktop/phone specifics
if ! defined(Q_OS_LINUX) || ! defined(Q_PROCESSOR_X86)

that is spread across functions, you should define another macro and put the temporary detection logic above in that macro instead.

Note: it seems that the ARM build is already complaining about it

« Back to merge proposal