Code review comment for lp:~abreu-alexandre/unity-webapps-qml/fail-safe-content-hub-bindings

Revision history for this message
Alberto Mardegan (mardy) wrote :

I don't think that you need to import the QtQuick 2.0 module.
Also, I'm not sure if the exception will always be thrown, or if it's possible for Qt.createQmlObject() to return null without raising the exception; if so, you should check for its return value != null as well.

But I'm not sure of either points, so if you have already tested this and this is the correct solution, +1 from me.

review: Approve

« Back to merge proposal