Merge lp:~abreu-alexandre/ubuntu-system-settings-online-accounts/use-hw-compositiing-oxide-rtm-1409 into lp:ubuntu-system-settings-online-accounts/rtm-14.09

Proposed by Alexandre Abreu
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 200
Merged at revision: 200
Proposed branch: lp:~abreu-alexandre/ubuntu-system-settings-online-accounts/use-hw-compositiing-oxide-rtm-1409
Merge into: lp:ubuntu-system-settings-online-accounts/rtm-14.09
Diff against target: 65 lines (+21/-1)
3 files modified
debian/control (+2/-0)
online-accounts-ui/main.cpp (+15/-0)
online-accounts-ui/online-accounts-ui.pro (+4/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/ubuntu-system-settings-online-accounts/use-hw-compositiing-oxide-rtm-1409
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
David Barth (community) Approve
Review via email: mp+239999@code.launchpad.net

Commit message

RTM14.09 backport of the fix for Bug #1377181: Account creation fails repeatedly, then it works

Description of the change

RTM14.09 backport of the fix for Bug #1377181: Account creation fails repeatedly, then it works

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) :
review: Approve
Revision history for this message
Alberto Mardegan (mardy) wrote :

Thanks!

review: Approve
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I grudgingly approve this since it fixes a critical bug, but I've filed bug #1387537

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2014-10-08 07:12:09 +0000
+++ debian/control 2014-10-29 14:18:07 +0000
@@ -13,7 +13,9 @@
13 libsystemsettings-dev (>= 0.1+13.10.20130806),13 libsystemsettings-dev (>= 0.1+13.10.20130806),
14 qt5-default,14 qt5-default,
15 qtbase5-dev,15 qtbase5-dev,
16 qtbase5-private-dev,
16 qtdeclarative5-dev,17 qtdeclarative5-dev,
18 qtdeclarative5-private-dev,
17 qtdeclarative5-accounts-plugin,19 qtdeclarative5-accounts-plugin,
18 qtdeclarative5-qtquick2-plugin,20 qtdeclarative5-qtquick2-plugin,
19 qtdeclarative5-test-plugin,21 qtdeclarative5-test-plugin,
2022
=== modified file 'online-accounts-ui/main.cpp'
--- online-accounts-ui/main.cpp 2014-08-07 13:41:03 +0000
+++ online-accounts-ui/main.cpp 2014-10-29 14:18:07 +0000
@@ -23,9 +23,15 @@
23#include "i18n.h"23#include "i18n.h"
24#include "ui-server.h"24#include "ui-server.h"
2525
26#include <QtGui/QOpenGLContext>
26#include <QGuiApplication>27#include <QGuiApplication>
27#include <QLibrary>28#include <QLibrary>
28#include <QProcessEnvironment>29#include <QProcessEnvironment>
30#if QT_VERSION < QT_VERSION_CHECK(5, 3, 0)
31#include <QtQuick/private/qsgcontext_p.h>
32#else
33#include <QtGui/private/qopenglcontext_p.h>
34#endif
2935
30using namespace OnlineAccountsUi;36using namespace OnlineAccountsUi;
3137
@@ -66,6 +72,15 @@
6672
67 initTr(I18N_DOMAIN, NULL);73 initTr(I18N_DOMAIN, NULL);
6874
75 // Enable compositing in oxide
76 QOpenGLContext *glcontext = new QOpenGLContext();
77 glcontext->create();
78#if QT_VERSION < QT_VERSION_CHECK(5, 3, 0)
79 QSGContext::setSharedOpenGLContext(glcontext);
80#else
81 QOpenGLContextPrivate::setGlobalShareContext(glcontext);
82#endif
83
69 QStringList arguments = app.arguments();84 QStringList arguments = app.arguments();
70 int i = arguments.indexOf("--socket");85 int i = arguments.indexOf("--socket");
71 if (i < 0 || i + 1 >= arguments.count()) {86 if (i < 0 || i + 1 >= arguments.count()) {
7287
=== modified file 'online-accounts-ui/online-accounts-ui.pro'
--- online-accounts-ui/online-accounts-ui.pro 2014-10-09 12:24:45 +0000
+++ online-accounts-ui/online-accounts-ui.pro 2014-10-29 14:18:07 +0000
@@ -13,7 +13,10 @@
13 dbus \13 dbus \
14 gui \14 gui \
15 qml \15 qml \
16 quick16 quick \
17 gui-private \
18 quick-private \
19 core-private
1720
18PKGCONFIG += \21PKGCONFIG += \
19 accounts-qt5 \22 accounts-qt5 \

Subscribers

People subscribed via source and target branches