Merge lp:~abreu-alexandre/ubuntu-html5-theme/remove-qt-private-deps into lp:ubuntu-html5-theme

Proposed by Alexandre Abreu
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 205
Merged at revision: 206
Proposed branch: lp:~abreu-alexandre/ubuntu-html5-theme/remove-qt-private-deps
Merge into: lp:ubuntu-html5-theme
Diff against target: 76 lines (+5/-21)
3 files modified
debian/control (+1/-2)
src/ubuntu-html5-app-launcher/CMakeLists.txt (+0/-2)
src/ubuntu-html5-app-launcher/main.cpp (+4/-17)
To merge this branch: bzr merge lp:~abreu-alexandre/ubuntu-html5-theme/remove-qt-private-deps
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu HTML5 Theme Developers Pending
Review via email: mp+257941@code.launchpad.net

Commit message

Update debian/control to remove qt private package deps; Rely on Qt 5.4's new API

Description of the change

Update debian/control to remove qt private package deps; Rely on Qt 5.4's new API

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2015-04-10 13:32:31 +0000
+++ debian/control 2015-04-30 17:31:40 +0000
@@ -9,8 +9,7 @@
9 python3-setuptools,9 python3-setuptools,
10 qt5-default,10 qt5-default,
11 qt5-qmake,11 qt5-qmake,
12 qtbase5-dev,12 qtbase5-dev (>= 5.4),
13 qtbase5-private-dev,
14 qtdeclarative5-dev,13 qtdeclarative5-dev,
15 qtdeclarative5-qtquick2-plugin,14 qtdeclarative5-qtquick2-plugin,
16 qtdeclarative5-ubuntu-ui-toolkit-plugin,15 qtdeclarative5-ubuntu-ui-toolkit-plugin,
1716
=== modified file 'src/ubuntu-html5-app-launcher/CMakeLists.txt'
--- src/ubuntu-html5-app-launcher/CMakeLists.txt 2014-12-16 21:02:55 +0000
+++ src/ubuntu-html5-app-launcher/CMakeLists.txt 2015-04-30 17:31:40 +0000
@@ -21,8 +21,6 @@
21)21)
22qt5_use_modules(${HTML5_LAUNCHER} Core Gui Widgets Quick)22qt5_use_modules(${HTML5_LAUNCHER} Core Gui Widgets Quick)
2323
24include_directories(${Qt5Quick_PRIVATE_INCLUDE_DIRS})
25
26# install qml files24# install qml files
27file(GLOB QML_FILES *.qml)25file(GLOB QML_FILES *.qml)
28install(FILES ${QML_FILES} DESTINATION ${CMAKE_INSTALL_DATADIR}/ubuntu-html5-app-launcher/qml)26install(FILES ${QML_FILES} DESTINATION ${CMAKE_INSTALL_DATADIR}/ubuntu-html5-app-launcher/qml)
2927
=== modified file 'src/ubuntu-html5-app-launcher/main.cpp'
--- src/ubuntu-html5-app-launcher/main.cpp 2015-03-16 17:48:23 +0000
+++ src/ubuntu-html5-app-launcher/main.cpp 2015-04-30 17:31:40 +0000
@@ -1,5 +1,5 @@
1/*1/*
2 * Copyright 2013 Canonical Ltd.2 * Copyright 2013-2015 Canonical Ltd.
3 *3 *
4 * This file is part of ubuntu-html5-ui-toolkit.4 * This file is part of ubuntu-html5-ui-toolkit.
5 *5 *
@@ -28,11 +28,6 @@
28#include <QQmlEngine>28#include <QQmlEngine>
29#include <QQmlContext>29#include <QQmlContext>
30#include <QQmlComponent>30#include <QQmlComponent>
31#if QT_VERSION < QT_VERSION_CHECK(5, 3, 0)
32#include <QtQuick/private/qsgcontext_p.h>
33#else
34#include <QtGui/private/qopenglcontext_p.h>
35#endif
3631
3732
38namespace {33namespace {
@@ -107,6 +102,9 @@
107102
108int main(int argc, char *argv[])103int main(int argc, char *argv[])
109{104{
105 // Enable compositing in oxide
106 QCoreApplication::setAttribute(Qt::AA_ShareOpenGLContexts);
107
110 QGuiApplication app(argc, argv);108 QGuiApplication app(argc, argv);
111109
112 if (!app.arguments().count())110 if (!app.arguments().count())
@@ -197,17 +195,6 @@
197 }195 }
198 setUpQmlImportPathIfNecessary();196 setUpQmlImportPathIfNecessary();
199197
200 // Enable compositing in oxide
201 QOpenGLContext* glcontext = new QOpenGLContext();
202 glcontext->create();
203#if QT_VERSION < QT_VERSION_CHECK(5, 3, 0)
204 QSGContext::setSharedOpenGLContext(glcontext);
205#elif QT_VERSION < QT_VERSION_CHECK(5, 4, 0)
206 QOpenGLContextPrivate::setGlobalShareContext(glcontext);
207#else
208 qt_gl_set_global_share_context(glcontext);
209#endif
210
211 QQuickView view;198 QQuickView view;
212 QQmlEngine* engine = view.engine();199 QQmlEngine* engine = view.engine();
213200

Subscribers

People subscribed via source and target branches