Merge lp:~abreu-alexandre/ubuntu-html5-theme/remove-qt-private-deps into lp:ubuntu-html5-theme

Proposed by Alexandre Abreu
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 205
Merged at revision: 206
Proposed branch: lp:~abreu-alexandre/ubuntu-html5-theme/remove-qt-private-deps
Merge into: lp:ubuntu-html5-theme
Diff against target: 76 lines (+5/-21)
3 files modified
debian/control (+1/-2)
src/ubuntu-html5-app-launcher/CMakeLists.txt (+0/-2)
src/ubuntu-html5-app-launcher/main.cpp (+4/-17)
To merge this branch: bzr merge lp:~abreu-alexandre/ubuntu-html5-theme/remove-qt-private-deps
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu HTML5 Theme Developers Pending
Review via email: mp+257941@code.launchpad.net

Commit message

Update debian/control to remove qt private package deps; Rely on Qt 5.4's new API

Description of the change

Update debian/control to remove qt private package deps; Rely on Qt 5.4's new API

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-04-10 13:32:31 +0000
3+++ debian/control 2015-04-30 17:31:40 +0000
4@@ -9,8 +9,7 @@
5 python3-setuptools,
6 qt5-default,
7 qt5-qmake,
8- qtbase5-dev,
9- qtbase5-private-dev,
10+ qtbase5-dev (>= 5.4),
11 qtdeclarative5-dev,
12 qtdeclarative5-qtquick2-plugin,
13 qtdeclarative5-ubuntu-ui-toolkit-plugin,
14
15=== modified file 'src/ubuntu-html5-app-launcher/CMakeLists.txt'
16--- src/ubuntu-html5-app-launcher/CMakeLists.txt 2014-12-16 21:02:55 +0000
17+++ src/ubuntu-html5-app-launcher/CMakeLists.txt 2015-04-30 17:31:40 +0000
18@@ -21,8 +21,6 @@
19 )
20 qt5_use_modules(${HTML5_LAUNCHER} Core Gui Widgets Quick)
21
22-include_directories(${Qt5Quick_PRIVATE_INCLUDE_DIRS})
23-
24 # install qml files
25 file(GLOB QML_FILES *.qml)
26 install(FILES ${QML_FILES} DESTINATION ${CMAKE_INSTALL_DATADIR}/ubuntu-html5-app-launcher/qml)
27
28=== modified file 'src/ubuntu-html5-app-launcher/main.cpp'
29--- src/ubuntu-html5-app-launcher/main.cpp 2015-03-16 17:48:23 +0000
30+++ src/ubuntu-html5-app-launcher/main.cpp 2015-04-30 17:31:40 +0000
31@@ -1,5 +1,5 @@
32 /*
33- * Copyright 2013 Canonical Ltd.
34+ * Copyright 2013-2015 Canonical Ltd.
35 *
36 * This file is part of ubuntu-html5-ui-toolkit.
37 *
38@@ -28,11 +28,6 @@
39 #include <QQmlEngine>
40 #include <QQmlContext>
41 #include <QQmlComponent>
42-#if QT_VERSION < QT_VERSION_CHECK(5, 3, 0)
43-#include <QtQuick/private/qsgcontext_p.h>
44-#else
45-#include <QtGui/private/qopenglcontext_p.h>
46-#endif
47
48
49 namespace {
50@@ -107,6 +102,9 @@
51
52 int main(int argc, char *argv[])
53 {
54+ // Enable compositing in oxide
55+ QCoreApplication::setAttribute(Qt::AA_ShareOpenGLContexts);
56+
57 QGuiApplication app(argc, argv);
58
59 if (!app.arguments().count())
60@@ -197,17 +195,6 @@
61 }
62 setUpQmlImportPathIfNecessary();
63
64- // Enable compositing in oxide
65- QOpenGLContext* glcontext = new QOpenGLContext();
66- glcontext->create();
67-#if QT_VERSION < QT_VERSION_CHECK(5, 3, 0)
68- QSGContext::setSharedOpenGLContext(glcontext);
69-#elif QT_VERSION < QT_VERSION_CHECK(5, 4, 0)
70- QOpenGLContextPrivate::setGlobalShareContext(glcontext);
71-#else
72- qt_gl_set_global_share_context(glcontext);
73-#endif
74-
75 QQuickView view;
76 QQmlEngine* engine = view.engine();
77

Subscribers

People subscribed via source and target branches