Merge lp:~abreu-alexandre/ubuntu-html5-theme/deprecate-html5-container-package into lp:ubuntu-html5-theme

Proposed by Alexandre Abreu
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 215
Merged at revision: 216
Proposed branch: lp:~abreu-alexandre/ubuntu-html5-theme/deprecate-html5-container-package
Merge into: lp:ubuntu-html5-theme
Diff against target: 13 lines (+1/-1)
1 file modified
debian/control (+1/-1)
To merge this branch: bzr merge lp:~abreu-alexandre/ubuntu-html5-theme/deprecate-html5-container-package
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+297345@code.launchpad.net

Commit message

Deprecate ubuntu-html5-container

Description of the change

Deprecate ubuntu-html5-container

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

If ubuntu-html5-sdk is supposed to replace the old ubuntu-html5-container, what you need is:
Conflicts: ubuntu-html5-container
Replaces: ubuntu-html5-container

review: Needs Fixing
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Actually, this package does not replace the functionality of ubuntu-html5-container, right? If not, then no Conflicts Breaks or Replaces should be present here. What's the case here? Shouldn't this simply depend on webapp-container instead?

review: Needs Information
215. By Alexandre Abreu on 2016-06-15

Add webapp-container deps

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

updated

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Excellent! If I understand correctly the package's situation, that's what should be done. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-06-04 21:55:47 +0000
3+++ debian/control 2016-06-15 13:31:50 +0000
4@@ -25,8 +25,8 @@
5 Package: ubuntu-html5-sdk
6 Architecture: all
7 Depends: qtdeclarative5-ubuntu-webapps-api,
8- ubuntu-html5-container,
9 ubuntu-html5-ui-toolkit,
10+ webapp-container,
11 Description: Ubuntu HTML5 SDK Metapackage
12 This package depends on all components of the HTML5 app stack, allowing
13 for easy installation of all necessary components.

Subscribers

People subscribed via source and target branches