Code review comment for lp:~abreu-alexandre/oxide/content-script-injection-main-world

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Updated,

There is one thing that in the inline comments I did not do (since I did not necessarily agree), it is about the specialized ScriptMessageManagerForWorldId for the main world along w/ a dedicated variable, I have the impression that it will complicate the code a bit and I find it relevant (eventhough it is only used from one context at this point) to have a very dedicated member function there,

« Back to merge proposal