Code review comment for lp:~abreu-alexandre/oxide/chromedriver-support

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks for this. I've left some comments inline. In addition to that:

- There should probably be a build-config option for enabling the chromedriver binary (ENABLE_CHROMEDRIVER ?)
- It's missing an install target.

review: Needs Fixing

« Back to merge proposal