Code review comment for lp:~abreu-alexandre/bamf/remove-webapps-deps

> All these things must not be removed, othewise chromium web-apps will stop
> working:
>
> 135 -is_web_app_window (BamfLegacyWindow *window)
>
> 177 - skip_hint_set = is_libreoffice_window (window) || is_web_app_window
> (window) || is_javaws_window (window);
>
> 185 {
> 186 - if (is_web_app_window (window))
> 187 - {
> 188 - // This ensures that a new application is created even for unknown
> webapps
> 189 - filter_by_wmclass = TRUE;
> 190 - }
> 191 - else
> 192 - {
> 193 - target_class = class_name;
> 194 - filter_by_wmclass = bamf_matcher_has_instance_class_desktop_file
> (self, target_class);
> 195 - }
> 196 + target_class = class_name;
> 197 + filter_by_wmclass = bamf_matcher_has_instance_class_desktop_file
> (self, target_class);
>

done

> As said, also, it would be nice to provide changes for libbamf as well not to
> make it to do anything, but warn about the fact these APIs are deprecated. And
> at the same way, deprecate all the methods into the headers, providing also a
> branch for unity.

we agreed, to do it in a second step to lower the risks since we would be playing
w/ libbamf & unity and it is a bit scary at this point in the cycle,