Code review comment for lp:~abhiram-ampabathina/gtg/gtg
Revision history for this message
| Izidor MatuĊĦov (izidor) wrote | # |
review:
Needs Fixing
(code, running)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Hi Abhiram,
the code works for me! Congratulation. I have some nitpicking to do:
* Please, set the default font to the current one. If users don't want to change the font, they use the same font as until now. Look at the difference: http://
* Put before font selecting widget description, something like "Font: "
* I found a small glitch:
1, Open GTG and set a new font in the preferences
2, Restart GTG
3, Open the preferences dialog -> there is the default font (Sans 12) instead of my font.
* It would be nice to change the name of the font button widget from fontbutton1 into fontbutton
* You added import pygtk twice. I think you can remove it and it should still work.
* Change "config1" into something like "browser_config" ? Maybe even better would be to store that configuration in the editor configuration.
You are doing good work and improving your hacking skills. Keep working and it will be easier :)