Merge lp:~abentley/launchpad/sharing-spinners into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 12854 |
Proposed branch: | lp:~abentley/launchpad/sharing-spinners |
Merge into: | lp:launchpad |
Diff against target: |
308 lines (+94/-20) 4 files modified
lib/lp/translations/javascript/sourcepackage_sharing_details.js (+31/-15) lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.html (+14/-5) lib/lp/translations/javascript/tests/test_sourcepackage_sharing_details.js (+33/-0) lib/lp/translations/templates/sourcepackage-sharing-details.pt (+16/-0) |
To merge this branch: | bzr merge lp:~abentley/launchpad/sharing-spinners |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+57888@code.launchpad.net |
Commit message
Add spinners to translation-sharing actions.
Description of the change
= Summary =
Fix bug #758922: Missing spinners on translations +sharing-details js actions
== Proposed fix ==
Add hidden spinners to web page, show them as needed.
== Pre-implementation notes ==
None
== Implementation details ==
Added a new "pending" boolean to checklist items. When this is true, the TranslationShar
== Tests ==
firefox lib/lp/
== Demo and Q/A ==
Go to the +sharing-details page for a SourcePackage. Ensure that when each setting is changed, a spinner is shown. This should happen both when the list item was formlerly uncheckd and when it was formerly checked.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/