Aaron this is a great change. Thanks for moving the comment and error functionality to a place they can be re-used.
The only tiny nit I have is at line 645 of the diff where you have an in-line comment, which our coding standards discourage.
« Back to merge proposal
Aaron this is a great change. Thanks for moving the comment and error functionality to a place they can be re-used.
The only tiny nit I have is at line 645 of the diff where you have an in-line comment, which our coding standards discourage.