Code review comment for lp:~abentley/launchpad/reuse-refactor

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =
Refactor the inline bug comment code for reuse, specifically by branch
merge proposals.

== Proposed fix ==
Extract the error handling code from bugtask-index.js into errors.js.
Extract the comment handling code into comment.js. Reorganize as a Widget.

== Pre-implementation notes ==
Preimplementation was with thumper.

== Implementation details ==
As a drive-by, the export of IBranchMergeProposal.createComment is
changed to export_factory_operation. This ensures that its return value
is usable.

== Tests ==
bin/test -v --layer=BugsWindmillLayer

== Demo and Q/A ==

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/code/interfaces/branchmergeproposal.py
  lib/canonical/launchpad/javascript/bugs/bugtask-index.js
  lib/canonical/launchpad/javascript/lp/errors.js
  lib/canonical/launchpad/interfaces/_schema_circular_imports.py
  lib/lp/bugs/templates/bugtask-index.pt
  lib/canonical/launchpad/javascript/lp/comment.js

== JSLint notices ==
jslint: No problem found in
'/home/abentley/launchpad/inline-comment/lib/canonical/launchpad/javascript/lp/comment.js'.

jslint: No problem found in
'/home/abentley/launchpad/inline-comment/lib/canonical/launchpad/javascript/lp/errors.js'.

jslint: No problem found in
'/home/abentley/launchpad/inline-comment/lib/canonical/launchpad/javascript/bugs/bugtask-index.js'.

jslint: 3 files to lint.

== Pylint notices ==

lib/lp/code/interfaces/branchmergeproposal.py
    27: [F0401] Unable to import 'lazr.lifecycle.event' (No module named
lifecycle)
    42: [F0401] Unable to import 'lazr.restful.fields' (No module named
restful)
    43: [F0401] Unable to import 'lazr.restful.declarations' (No module
named restful)

lib/canonical/launchpad/interfaces/_schema_circular_imports.py
    18: [F0401] Unable to import 'lazr.restful.declarations' (No module
named restful)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrUklMACgkQ0F+nu1YWqI0TIgCfcsmvIb+qgNSDBGRnDyciBJvh
h3gAnin+FvxrnRxj4Miho4vOzpQF912z
=+Dh5
-----END PGP SIGNATURE-----