Merge lp:~abentley/launchpad/mustache-bugs into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 14193 | ||||
Proposed branch: | lp:~abentley/launchpad/mustache-bugs | ||||
Merge into: | lp:launchpad | ||||
Prerequisite: | lp:~abentley/launchpad/support-mustache | ||||
Diff against target: |
450 lines (+328/-2) 8 files modified
lib/lp/bugs/browser/bugtask.py (+44/-0) lib/lp/bugs/browser/tests/test_bugtask.py (+136/-1) lib/lp/bugs/javascript/buglisting.js (+23/-0) lib/lp/bugs/javascript/tests/test_buglisting.html (+32/-0) lib/lp/bugs/javascript/tests/test_buglisting.js (+58/-0) lib/lp/bugs/templates/buglisting-default.pt (+3/-1) lib/lp/bugs/templates/buglisting.mustache (+25/-0) lib/lp/bugs/templates/bugs-listing-table-without-navlinks.pt (+7/-0) |
||||
To merge this branch: | bzr merge lp:~abentley/launchpad/mustache-bugs | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Benji York (community) | code | Approve | |
Review via email: mp+79441@code.launchpad.net |
Commit message
Implement new bug listing style on server-side and client-side.
Description of the change
= Summary =
Fix bug 874595: bug listings need to follow new style
== Proposed fix ==
Use Mustache to render new bugs client-side and server-side.
Screenshot: http://
== Pre-implementation notes ==
Discussed with deryck
== Implementation details ==
This is hidden behind a feature flag (bugs.dynamic_
The Mustache template is provided as a separate file, which is loaded by the view class, and provided in JSON form as LP.mustache_
The data to be rendered is provided as LP.cache.
== Tests ==
bin/test -t buglisting -t test_bugtask
== Demo and Q/A ==
Enable the flag. Go to +bugs for a given project or source package. You should see a display similar to the screenshot above.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
versions.cfg
setup.py
utilities/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
utilities/
utilities/
lib/lp/
lib/lp/
This is for https:/ /dev.launchpad. net/Projects/ CustomBugListin gs