Code review comment for lp:~abentley/launchpad/invalid-sig

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =
Stop handling InvalidSignature as an OOPS, instead handle as user error.

== Proposed fix ==
Implement a new _handle_user_error method, and use it.

== Pre-implementation notes ==
None

== Implementation details ==
Until now, handleIncoming has only had doctests, not unittests.

== Tests ==
bin/test test_incoming -t test_invalid_signature

== Demo and Q/A ==
Send a message with an invalid signature. The resulting error message
should explain what the problem was.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/mail/incoming.py
  lib/canonical/launchpad/mail/tests/test_incoming.py
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkp4np4ACgkQ0F+nu1YWqI3JLwCfQvI5Hd/gM/FTz7a7I5yHrDFn
J54AmgLOpZ1v+7r+HQ6ZBQuVRMFktEpJ
=pIUT
-----END PGP SIGNATURE-----

« Back to merge proposal