Code review comment for lp:~abentley/launchpad/hide-numbers

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =
Partial fix for #382561: Provide the ability to show and hide line
numbers in the preview diff, using a checkbox.

Note that a fully-functional workaround for #382561 is to use the
"Download diff" link.

== Proposed fix ==

== Pre-implementation notes ==
Pre-implementation was with Thumper

== Implementation details ==
The config and Makefile changes were done so that it was possible to
generate a diff in the developer environment.

The checkbox is implemented as a Widget called NumberToggle.

== Tests ==
None

== Demo and Q/A ==
 Create a merge proposal with a diff. Click the checkbox (or the
phrase) "Show line numbers".

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/code/templates/branchmergeproposal-index.pt
  lib/canonical/launchpad/javascript/code/codereview.js
  Makefile
  configs/development/launchpad-lazr.conf

== JSLint notices ==
No handlers could be found for logger "bzr"
jslint: Lint found in
'/home/abentley/launchpad/hide-numbers/lib/canonical/launchpad/javascript/bugs/bugtask-index.js':
Line 584 character 31: ['api_uri'] is better written in dot notation.
        var branch_url = data['api_uri'];

^^^ I didn't change this file!

jslint: No problem found in
'/home/abentley/launchpad/hide-numbers/lib/canonical/launchpad/javascript/code/codereview.js'.

jslint: 2 files to lint.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrl+fcACgkQ0F+nu1YWqI2KtACePSXRjpjFE1lfIwppl6QLmBe2
gmoAnRNlwDgwMDWrxXsiGRCPimxEwgHp
=5eM5
-----END PGP SIGNATURE-----