Code review comment for lp:~abentley/launchpad/gmail-inline

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =
As seen in bug #401772, Gmail doesn't display diffs inline unless the
content-type is text/plain or the file extension is .txt.

== Proposed fix ==
Change the file extensions of generated diffs to be .txt. This will
appease Gmail, but clients which respect the text/x-diff content-type
will be unaffected.

== Pre-implementation notes ==
Pre-imp with Thumper

== Implementation details ==
None

== Tests ==
bin/test mail.tests -t test_generateEmail_with_diff -t
test_generateEmail_attaches_diff

== Demo and Q/A ==
Generate merge proposal emails and branch revision emails containing
diffs. Jam them into Gmail somehow. Possibly download the raw bytes
from staging, and use a Python script to resend to Gmail.

View them on Gmail. Observe whether they're displayed inline.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/code/mail/tests/test_branch.py
  lib/lp/code/mail/branchmergeproposal.py
  lib/lp/code/mail/tests/test_branchmergeproposal.py
  lib/lp/code/mail/branch.py
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpnX2MACgkQ0F+nu1YWqI2o1wCghdKG6QUdLZYG2yBXfP8Z35+R
A98AniLXLW0vp2sD5FrgHX2/9rsTNJrF
=HTT3
-----END PGP SIGNATURE-----