Merge lp:~abentley/launchpad/fix-index-download into lp:launchpad
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 14749 | ||||||||
Proposed branch: | lp:~abentley/launchpad/fix-index-download | ||||||||
Merge into: | lp:launchpad | ||||||||
Prerequisite: | lp:~abentley/launchpad/attachment-timeout | ||||||||
Diff against target: |
103 lines (+35/-15) 3 files modified
lib/lp/code/browser/codereviewcomment.py (+9/-6) lib/lp/code/browser/configure.zcml (+7/-3) lib/lp/code/browser/tests/test_branchmergeproposal.py (+19/-6) |
||||||||
To merge this branch: | bzr merge lp:~abentley/launchpad/fix-index-download | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Deryck Hodge (community) | Approve | ||
Review via email: mp+91160@code.launchpad.net |
Commit message
Only comment index pages may redirect to +download.
Description of the change
= Summary =
Fix bug #924926: comment download redirect on main merge proposal page
== Proposed fix ==
Render +index using a subclass of CodeReviewComme
== Pre-implementation notes ==
None
== Implementation details ==
Attempted to avoid subclassing by moving the redirect code to a method and using "attribute" to select that method in the zcml, but it did not work.
== Tests ==
bin/test -t test_excessive_
== Demo and Q/A ==
Create a comment that is more than 10,000 characters long. Go to its merge proposal page. The page should show normally.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/