comment download redirect on main merge proposal page
Bug #924926 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Aaron Bentley | ||
Bug Description
lp:~abentley/launchpad/attachment-timeout has a bug when comments are excessively long. The merge proposal page should provide a link to the download, and a permalink, but should not provide a download dialog. But for some reason, it is providing a download dialog, which prevents the whole page from being visible.
Related branches
lp:~abentley/launchpad/fix-index-download
- Deryck Hodge (community): Approve
-
Diff: 103 lines (+35/-15)3 files modifiedlib/lp/code/browser/codereviewcomment.py (+9/-6)
lib/lp/code/browser/configure.zcml (+7/-3)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+19/-6)
| Changed in launchpad: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r14749 <http://