Code review comment for lp:~abentley/launchpad/duplicate-msgid

On Tue, May 31, 2011 at 2:52 PM, Aaron Bentley <email address hidden> wrote:
>
> My change causes it to dump messages with duplicate msgids on the floor.
>  I don't see how it can cause a any link to be created.

I was unclear; sorry. If the patch were extended to call a handler
when messageset.get(rfc822id) returned a message, it would do this.

>> The functional hole is that a new message with an existing id will not have its mail handler called, which means that a mail sent to two bugs, or to two mailing lists, or any such pair of objects will only be added to one of the objects.
>
> Surely we process each message only once, no matter how many bugs it's
> associated with?

No. We process it once per address. We receive the same message
multiple times with different envelope-to headers.

-Rob