The code looks great and the change is minimal, so r=me. As we discussed on IRC, we should try to avoid log output for pages when the behavior is normal and not exceptional, but I take the point that this helps people debug what's happening here. I'm fine for it to stand if we log at a lower priority, i.e. to debug. We can turn it on if we need, but it's not noising on normal page requests.
Thanks for being flexible and being willing to fix this up. Approved with that change.
The code looks great and the change is minimal, so r=me. As we discussed on IRC, we should try to avoid log output for pages when the behavior is normal and not exceptional, but I take the point that this helps people debug what's happening here. I'm fine for it to stand if we log at a lower priority, i.e. to debug. We can turn it on if we need, but it's not noising on normal page requests.
Thanks for being flexible and being willing to fix this up. Approved with that change.