Code review comment for lp:~abentley/launchpad/bzr-2.2.2-lp-1

Revision history for this message
Benji York (benji) wrote :

Approved.

I did not review the bzr changes, but am instead assuming that the bzr
guys' review caught anything that I would have.

Regarding making the needed changes to the bzr 2.2 tip verses applying
just the changes we need to the version of bzr we currently use: If the
tests pass, I'd rather track 2.2 than diverge further from it because I
have no reason not to believe that the bzr guys make reasonable
decisions in choosing what changes to make there (i.e., low risk bug
fixes). I am not aware of any policy we have regarding this.

review: Approve (code*)

« Back to merge proposal