Code review comment for lp:~abentley/launchpad/build-mail3

Revision history for this message
j.c.sackett (jcsackett) wrote :

After talking in IRC, my performance question has been addressed.

11:57 AM jcsackett
abentley: builds is a SQLMultipleJoin; i'm wondering if when self.build gets called we may return a huge rowset in some cases.
11:57 AM abentley
jcsackett, as I said, it's always one or zero results.
11:57 AM jcsackett
abenltey, ah! i thought you meant from_build was called one or zero times.
11:57 AM abentley
jcsackett, there is a comment in the code saying it shouldn't be a multiple join.
11:59 AM jcsackett
abentley: yes, i see now.
11:59 AM
apologies for the confusion.

review: Approve (code*)

« Back to merge proposal