Code review comment for lp:~abentley/bzr/is_executable

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/29/2010 9:59 PM, Aaron Bentley wrote:
> Aaron Bentley has proposed merging lp:~abentley/bzr/is_executable into lp:bzr with lp:bzr/2.2 as a prerequisite.
>
> Requested reviews:
> bzr-core (bzr-core)
>
>
> Hi all,
>
> This branch fixes RevisionTree.is_executable to treat directories and symlinks
> the same way as other Tree implementations-- to return False rather than None.
> The revised behaviour is also consistent with RevisionTree._comparison_data.
>
> This problem filters up and affects Launchpad's incremental diffs for merge
> proposals (which are disabled until this issue can be resolved), causing them
> to erroneously report property changes on directories and symlinks
> that have not changed.
>
> Three tests have been affected, but FWICT, they were testing actual behaviour,
> not desirable behaviour. Specifically, the ROOT_ENTRY should only be included
> in iter_changes-style output when it has changed, when it has a new child, or
> when include_unchanged is specified.

I think this is perfectly fine to land in trunk. Just need some
discussion about landing it in the 2.2 series.

 merge: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkz1EXMACgkQJdeBCYSNAAMqmgCfRgyrNe8o9fbMI8dT7d7g88ZC
cYgAn21lp1gOXUpMJmeAuY+vCo9dR5e7
=Yd01
-----END PGP SIGNATURE-----