Code review comment for lp:~abentley/bzr/fix-switch-branch

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> John A Meinel wrote:
>> Review: Approve
>> There is an open bug on this, in fact there are like 3. It should be mentioned in NEWS. Otherwise:
>
> The bug is 559436, and it even has a fix I wrote that is still waiting for
> review:
>
> <https://code.edge.launchpad.net/~spiv/bzr/switch-crash-559436/+merge/23817>
>
> Happily it's essentially the same as Aaron's fix, but I wonder why his got
> reviewed already when mine from 3 days earlier is still waiting? Is it because
> I targetted 2.1?
>
> -Andrew.
>

For my part, it is because his e-mail showed up while I was willing to
review. Plus it has a test...

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkvWTdYACgkQJdeBCYSNAAMz+ACfQDdyJMctqtqSbbWmbqLsc47A
bRQAoLEbH1DrgPQWMd39+7XNfqMpcSw0
=exb9
-----END PGP SIGNATURE-----

« Back to merge proposal