Code review comment for lp:~abentley/bzr/config-branchname

Revision history for this message
John A Meinel (jameinel) wrote :

Offhand it feels like we would need to unescape the basename if we are unescaping the branch portion. However your test seems to clearly state that isn't the case. That indicates we prob have an API issue (similar commands return different types, eg escaped URLs vs Unicode). But that isn't something you need to fix in this branch.

The doc seems a bit incomplete as it only indicates branchname works with Colo branches.

review: Approve

« Back to merge proposal