That looks reasonable to me, though James might like to review it too.
Needing to pass around the 'instruction' quite so much suggests perhaps splitting out a class that knows the instruction it's parsing?
« Back to merge proposal
That looks reasonable to me, though James might like to review it too.
Needing to pass around the 'instruction' quite so much suggests perhaps splitting out a class that knows the instruction it's parsing?