Code review comment for lp:~ab-tools/widelands/msvs2010-compilewarnings

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Regarding the CMake warnings, check CMakeList.txt lines 206 and 213. They are in if clauses already. If the compiler supports the additional warnings, they are appended to the options used, otherwise the warnings you saw are printed. This was done both to explain why the additional warnings aren't used and to avoid silently using less without being told why. I guess I could somehow improve the warnings to make this a bit clearer, at least mention Visual Studio as an alternative in the GCC-only warning.

« Back to merge proposal