Code review comment for lp:~aauzi/midori/fix-1179624

Revision history for this message
André Auzi (aauzi) wrote :

> 278 +midori_bookmarks_statusbar_update (MidoriBookmarks *bookmarks)
>
> I would prefer it all text in the statusbar starts uppercase, "Empty folder",
> "Folder containing" and so on, otherwise it will look poor, spelling has an
> incredible impact on how you see text
>
> 323 + text = g_strdup_printf (_("bookmark leading to : %s"),
> uri)
>
> No space before : in English
>
> 406 +midori_bookmarks_get_item_at_pos (GtkTreeView *treeview,
> 412 + KatzeItem* item;
> 420 + if (gtk_tree_model_get_iter (model, &iter, path))
> 421 + gtk_tree_model_get (model, &iter, 0, &item, -1);
>
> I read an undefined item there if the condition is FALSE.
>
> If you could sort out these last nitpickes I think the patch is good to go

No problem. Done.

review: Needs Resubmitting

« Back to merge proposal