Can you maybe "pack" such statements? I don't think this style is used in midori code and it
balloons the patch as well. I see it a couple of places.
+ text = g_strdup_printf(_("%s : folder, %s and %s"),
+ name, child_bookmarks_str, child_folders_str);
Something like this is still readable i think.
As for translatable strings it would be wise to add comments for translators there
/* i18n: some explanation */ Should help those reading the code as well.
Otherwise code looks good. Let's see again after update.
Looks promising.
Please resolve conflicts and drop webapp code, it should slim the patch a bit
making it easier to read.
47 + text = g_strdup_printf( _str,
448 + _("%s : folder, %s and %s"),
449 + name,
450 + child_bookmarks
451 + child_folders_str);
Can you maybe "pack" such statements? I don't think this style is used in midori code and it
balloons the patch as well. I see it a couple of places.
+ text = g_strdup_ printf( _("%s : folder, %s and %s"), _str, child_folders_str);
+ name, child_bookmarks
Something like this is still readable i think.
As for translatable strings it would be wise to add comments for translators there
/* i18n: some explanation */ Should help those reading the code as well.
Otherwise code looks good. Let's see again after update.